search

jasperweyne / helpless-kiwi

Manage members, create and manage activities, send mails and more
Apache License 2.0
11 stars 7 forks source link

PR for template activities. #346

Closed mattijsgietman closed 1 year ago

mattijsgietman commented 1 year ago

Hi,

In this PR I made an extra feature for making activities.

It is now possible for activities to be saved as a template ("sjabloon"). This can then be used to make new activities. This feature can be usefull, for when there are repeating activities.

Could someone take a look at this?

A-Daneel commented 1 year ago

Hey,

Took a quick look at your changes. I see that you've edited two entities, but didn't include a migration.

Apart from that it looks pretty nice. Once you've committed your migration I can take a look locally.

jasperweyne commented 1 year ago

Hi, I was wondering, what would be a motivation to store an activity as a template? Wouldn't it be sufficient to add a copy button to an activity?

A-Daneel commented 1 year ago

Personally I think the advantage of a template would be the ability to only save the fields that are the same every time, reducing the chances of wrong data in your new activity.

It would also be more convenient for something like a big party you do every year, not having to search for it.

still am curious to hear @mattijsgietman's thoughts.

mattijsgietman commented 1 year ago

Hi @A-Daneel and @jasperweyne ,

Thanks for the feedback on this PR. I will be adding a migration. for this PR shortly (probably today or next week monday).

And to answer @jasperweyne 's question: 'what would be a motivation to store an activity as a template? Wouldn't it be sufficient to add a copy button to an activity'

I think that the added benefit of a template (Sjabloon) would be a couple things. First of all indeed the person making the activity won't have to search for the activity through all archived activities. Resulting in a clean overview for activities that are organised every so often.

If there is any fear of the list getting cluttered by activities that are saved as templates , than there is still the option to make changes to the activity and saving it as a non-template.

Hope this answers your questions, and I'll let you know more about the migrations!

jasperweyne commented 1 year ago

Partially covered by #380, can be further resolved with work on #385. I'm going to close this for now.