javascriptdata / danfojs

Danfo.js is an open source, JavaScript library providing high performance, intuitive, and easy to use data structures for manipulating and processing structured data.
https://danfo.jsdata.org/
MIT License
4.81k stars 209 forks source link

read_excel with file object source #339

Closed Lu-David closed 2 years ago

Lu-David commented 2 years ago

I noticed in the danfojs docs that the read_excel method only takes in a string for the file path or url. The other methods, read_csv and read_json, both can read in file objects.

Would it be possible to add functionality to read_excel so that it can also read from a file object to dataframe? I'm wondering if there were any issues regarding implementing this functionality in the first place?

Thanks!

risenW commented 2 years ago

@Lu-David read_excel also supports loading of file objects, we probably missed adding that in the documentation.

risenW commented 2 years ago

Update: Documentation has been updated! https://danfo.jsdata.org/api-reference/input-output/danfo.read_excel#reading-an-input-file-object-in-the-browser