Added started project time to aggregate and report

jazzband / Watson

:watch: A wonderful CLI to track your time!

http://tailordev.github.io/Watson/

MIT License

2.46k stars 240 forks source link

Added started project time to aggregate and report #462

Closed Spiegie closed 2 years ago

Spiegie commented 2 years ago

added new flag (-i) to ignore started Project
added ignore_current as parameter to functions
changed behavior of report function to add started project time

It bothered me, that my current started Project does not count to the Time displayed for "watson report" and "watson aggregate"

That is my first contribution to a project. Please be gentle, if I did something not the right way

Spiegie commented 2 years ago

Please tell me, if I need to update the Docs for this change. If so, I will do my best to do that.

jmaupetit commented 2 years ago

Hi @Spiegie :wave:

Thank you for implementing this :pray: Can you add tests to this PR? Thx again!

Spiegie commented 2 years ago

Thank you for your Feedback @jmaupetit . I am not experienced with tests, but I will learn it. As long, I don't have implemented the Test, I will mark this PR as WIP

jmaupetit commented 2 years ago

No problem with that, take a look at already implemented tests. Take your time. :pray:

Spiegie commented 2 years ago

Finally, I found some time to learn about tests. I hope the Tests, I added, are enough. Please tell me, if I should do more.

Spiegie commented 2 years ago

im closing this PR It tourned out, the changes have some Issues. I dont have the time to fix it.