search

jbloomlab / phydms

phylogenetic analyses informed by deep mutational scanning data
GNU General Public License v3.0
14 stars 4 forks source link

Typo in tutorial? #45

Closed gavinmdouglas closed 4 months ago

gavinmdouglas commented 6 months ago

Hi there,

I believe this is a typo in the tutorial:

df["preference"] = [max(minenrichment, (10**df["Trial_1_AmpConc_2500"][x] + 10**df["Trial_1_AmpConc_2500"][x])/2) for x in range(len(df))]

I'm assuming that line is meant to calculate the mean of the Trial_1_AmpConc_2500 and Trial_2_AmpConc_2500, but Trial_1_AmpConc_2500 is specified each time.

Cheers,

Gavin

jbloom commented 4 months ago

Yes, you are correct this is a typo, although it obviously only affects the tutorial, not the actual software package itself.

Thanks for catching this. Are you up for submitting a pull request to fix the tutorial typo?

gavinmdouglas commented 4 months ago

Sure, I just made a pull request: https://github.com/jbloomlab/phydms/pull/46