jbloomlab / polyclonal

Model mutational escape from polyclonal antibodies.
Other
3 stars 0 forks source link

version 3.0: adjust regularization weights, add examples #136

Closed jbloom closed 1 year ago

jbloom commented 1 year ago

This version makes the uniqueness and spatial regularization part of the standard package. Changes regularization defaults and a few other non-backward-compatible changes.

jbloom commented 1 year ago

@Bernadetadad @caelanradford @Caleb-Carr @fwelsh @timcyu @matsen, I just merged this pull request which creates version 3.0.

The main changes are summarized in the CHANGELOG, and include everything in both version 2.6 and 3.0: https://github.com/jbloomlab/polyclonal/blob/main/CHANGELOG.rst

Documentation is here: https://jbloomlab.github.io/polyclonal/index.html

Key things:

I have not yet integrated this into dms-vep-pipeline, but can do so. But first, can you take a look over above and see if there are any relevant issues you spot that should be addressed before integrating into pipeline? If you find any, just post them here.

fwelsh commented 1 year ago

Haven't gotten to testing the update yet, but minor note for the docs. My last seq run returned much better antibody cocktail data now that reflects updated selection conditions. Here's the prob_escape file:

libA_221108_1_1C04-5G04_1_prob_escape.csv.zip

Would suggest updating the antibody cocktail example in the docs with this data instead!