search

jbloomlab / polyclonal

Model mutational escape from polyclonal antibodies.
Other
3 stars 0 forks source link

re-run notebooks and fix `Altair` plots #37

Closed jbloom closed 2 years ago

jbloom commented 2 years ago

@timcyu, as you noted, fixing the spread regularization might slightly change numerical results. Also, some of the altair plots still look strange (like here). I'm not sure if that is because they just need to be re-run and committed with fixes you've already made, or something still needs to be fixed. But related to this, they just released altair 4.2. So if you are doing this, you could also update requirement to >=4.2 when you re-run stuff just so we are using latest version of it. That is also what I now have installed in BloomLab conda environment.

timcyu commented 2 years ago

Sounds good, will work on this!

jbloom commented 2 years ago

@timcyu what is the status of this?

timcyu commented 2 years ago

@jbloom sorry I let this drop off my radar as I thought it'd be worth waiting for other changes before doing this. I'll do it now!