jbloomlab / polyclonal

Model mutational escape from polyclonal antibodies.
Other
3 stars 0 forks source link

fix max in distinct epitopes `altair` plots #85

Closed jbloom closed 2 years ago

jbloom commented 2 years ago

@timcyu, sorry I didn't catch this when doing the review of #84, but for the altair bar plots I think it would be better if you fix the x-axis scale to go from 0 to 1. I believe this is done by domain or range (can't remember) in Scale within the X encoding. The reason is that right now the interactive plots sometimes make it look like a big difference, but that's because the x-axis scale shrinks with data and isn't always covering the relevant range from 0 all the way to 1.

jbloom commented 2 years ago

Fixed in #86