search

jbrry / Irish-BERT

Repository to store helper scripts for creating an Irish BERT model.
Other
9 stars 0 forks source link

add rclone --drive-shared-with-me flag for shared folder #113

Closed jowagner closed 2 years ago

jowagner commented 2 years ago

Address issue #112.

Google changed the behaviour of shared folders a few times over the last years. The "Add to drive" trick to make shared folders accessible in rclone no longer works.

This PR adds --drive-shared-with-me to all our download scripts. Unfortunately, this breaks access for the owner of the "Theme A DCU" folder, Jennifer, if it is not already broken for her, e.g. if "Theme A DCU" is not in her root folder. Adding code to omit --drive-shared-with-me when she runs the script is probably not enough as the path to "Theme A DCU" probably must also be adjusted. I'd just leave it broken for Jennifer for now and she will figure out what's wrong when she tries to run these scripts. By the time something else may have changed and render the scripts non-functional anyway.

We can then release v0.1.1 so that team members downloading the current release do not run into this problem. (Outsiders won't have access to the folder anyway.)

jbrry commented 2 years ago

Looks great thanks. Yes, it will be more practical for the owner to modify any download scripts themselves.