search

jcgharvey / vsm-svr

0 stars 1 forks source link

Subname searching: bug or feature? #5

Closed ungarst closed 11 years ago

ungarst commented 11 years ago

At the moment when searching for names it will match mid name.

Example: If the name is "Dave Carpenter" it will match on "penter".

This is good for hyphenated names e.g. "Jess Hallett-Hook" where you can search "Hook" and you will match but bad for if you are looking for "Ben Hooker" but the search will match "Jess Hallett-Hook".

Should we make full word searching only or keep this behaviour. Please enter thoughts @bighuggies @bio595 @Luey @thomlug @jcgharvey

NB: This could be adjusted to rank search results but not at this point.

thomlug commented 11 years ago

I'd vote for matching the first part of words only, eg carp matches carpenter On 28/04/2013 5:30 PM, "Dave Carpenter" notifications@github.com wrote:

At the moment when searching for names it will match mid name.

Example: If the name is "Dave Carpenter" it will match on "penter".

This is good for hyphenated names e.g. "Jess Hallett-Hook" where you can search "Hook" and you will match but bad for if you are looking for "Ben Hooker" but the search will match "Jess Hallett-Hook".

Should we make full word searching only or keep this behaviour. Please enter thoughts @bighuggies https://github.com/bighuggies @bio595https://github.com/bio595 @Luey https://github.com/Luey @thomlug https://github.com/thomlug @jcgharvey https://github.com/jcgharvey

NB: This could be adjusted to rank search results but not at this point.

— Reply to this email directly or view it on GitHubhttps://github.com/jcgharvey/vsm-svr/issues/5 .

icbmike commented 11 years ago

I don't think it's really a problem. :|

Luey commented 11 years ago

I say keep it.

jcgharvey commented 11 years ago

Why don't we match start of words and start of words after hyphens? e.g. Carp Matches Carpenter Hook matches Jess Hallett-Hook Hook does not match Chook

-_- Hybrid

bighuggies commented 11 years ago

Match after word boundaries? Then we can do McMillan and stuff too. On 9/05/2013 9:00 AM, "Jourdan Harvey" notifications@github.com wrote:

Why don't we match start of words and start of words after hyphens? e.g. Carp Matches Carpenter Hook matches Jess Hallett-Hook Hook does not match Chook

-_- Hybrid

— Reply to this email directly or view it on GitHubhttps://github.com/jcgharvey/vsm-svr/issues/5#issuecomment-17633498 .

j-halletthook commented 11 years ago

I agree with Hugster

icbmike commented 11 years ago

Suddenly a random @j-halletthook appears :o

BESTGROUP uses Public Repo!

It's not very effective ...

@bighuggies can has example of how that would work? I assume with "McMillan", "Mc" and "Mil" would both match?

bighuggies commented 11 years ago

Yup On 9/05/2013 10:53 PM, "Michael Little" notifications@github.com wrote:

Suddenly a random @j-halletthook https://github.com/j-halletthookappears :o @bighuggies https://github.com/bighuggies can has example of how that would work? I assume with "McMillan", "Mc" and "Mil" would both match?

— Reply to this email directly or view it on GitHubhttps://github.com/jcgharvey/vsm-svr/issues/5#issuecomment-17658799 .

Luey commented 11 years ago

@bighuggies After discussion with @ungarst we have decided that implementing search on the API is out of the scope of this project. We will continue to use angular for searching.