search

jclehner / bcm2-utils

Utilities for Broadcom-based cable modems
GNU General Public License v3.0
136 stars 22 forks source link

cm500: Allow dumping flash over UART #66

Closed redawl closed 1 week ago

redawl commented 2 weeks ago

I forgot that what was holding me back from adding flash dump for cm500, was that I didn't know the flash partition layout, but now that's added, I was able to add SpiFlashWrite. Tested successfully dumping image1.

redawl commented 1 week ago

Bumping in case you missed this PR, since it was so close to the previous one. Also wanted to mention that I am maintaining an ebuild in the GURU Gentoo overlay, not sure if you want to mention that in the readme or not.

jclehner commented 1 week ago

It's been more than a decade since I've touched Gentoo and ebuilds, but I've noticed you put dev-libs/boost in RDEPEND. All Boost libraries used by bcm2-utils are header-only, so they are only required for building, not for running. On the other hand, shouldn't you add dev-libs/openssl to both DEPEND and RDEPEND?

redawl commented 1 week ago

It's been more than a decade since I've touched Gentoo and ebuilds, but I've noticed you put dev-libs/boost in RDEPEND. All Boost libraries used by bcm2-utils are header-only, so they are only required for building, not for running. On the other hand, shouldn't you add dev-libs/openssl to both DEPEND and RDEPEND?

You may be right. I'll take a look.

I'm pretty new to writing ebuilds, so thanks for the feedback!