Instructor Feedback Week 15

[pawaitemadisoncollege]

I know you've been working hard on this project and I'm really looking forward to seeing the final product! Nice job with logging, creating small, single-purpose methods, and recovering from many project changes/dead ends along the way!

• [ ] Time Log, Journal and Project plan need to be updated (Time log and Journal currently go through week 4 and week 7)
• [ ] What is the user experience when something goes wrong, i.e., the database is down? Custom error page/s can help with this.
• [ ] Remember javadoc -the plugin can really give you a jumpstart on this work.
• [ ] I'm a little concerned about the scope of these https://github.com/jdanner1/CANS/blob/3fbe708c323e1224c0cb0d387428730c4d1a0cd5/src/main/java/com/danner/controller/DeleteUserActionServlet.java#L31-L33. Since there's only one instance of the Servlet, all users will share a single instance of these daos. It's safer to make them local variables. Names of those could be improved too ;). Something like userDao, vocalizationDao, RoleDao.
• [ ] It would be more efficient to get the Vocalizations for a user, rather than filtering through all of them manually: https://github.com/jdanner1/CANS/blob/3fbe708c323e1224c0cb0d387428730c4d1a0cd5/src/main/java/com/danner/controller/DeleteUserActionServlet.java#L62-L66 and here https://github.com/jdanner1/CANS/blob/3fbe708c323e1224c0cb0d387428730c4d1a0cd5/src/main/java/com/danner/controller/HistoryServlet.java#L51-L55, and here https://github.com/jdanner1/CANS/blob/3fbe708c323e1224c0cb0d387428730c4d1a0cd5/src/main/java/com/danner/controller/DeleteUserActionServlet.java#L72-L76, for example. You might use this for inspiration: https://github.com/MadJavaEntFall2018/FatBikeTrailReports/blob/19ee364bbd5c03010d35d6daf211097eeb1a049e/src/main/java/com/paulawaite/fbtr/persistence/GenericDao.java#L109-L124
• [ ] Overall, unit tests look, but could be more thorough. Example: https://github.com/jdanner1/CANS/blob/3fbe708c323e1224c0cb0d387428730c4d1a0cd5/src/test/java/com/danner/persistence/UserDaoTest.java#L34 would be improved by comparing the full expected to actual entity.
• [ ] Is the unit test for VoiceFiler commented out to prevent maxing out your calls to the service? If so, document the class to that effect. Might use @ignore - I think that way junit even "reminds" you that you have something ignored.