search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Discuss #12

Closed jdev082 closed 2 years ago

jdev082 commented 2 years ago
  1. Make the search bar and go button on same line

Any suggestions?

hello-smile6 commented 2 years ago

@JaydenDev I could help, wait a moment. Currently running npm install

hello-smile6 commented 2 years ago

@JaydenDev Finished install, looking at it. Just wondering, how do you feel about loading the Chromium system stylesheet for now, just to get a good color scheme?

jdev082 commented 2 years ago

@hello-smile6 I'm fine with the userchrome.css configuration in config/

hello-smile6 commented 2 years ago

@hello-smile6 I'm fine with the userchrome.css configuration in config/

Could I import it from https://cursive.apps.chrome/chrome-apps-a4_202111181400_RC00_prod/a4_cros_stylesheet.css or somewhere? It'd just add environment variables for colors.

jdev082 commented 2 years ago

Any CSS file will work with FreeCat, although the bloat might not be great :/. Maybe release it as an addon, or add it as an addon.

hello-smile6 commented 2 years ago

Any CSS file will work with FreeCat, although the bloat might not be great :/. Maybe release it as an addon, or add it as an addon.

If you'd be okay with it, I could add a build script that loads dependencies like that from a list, and uses empty files for dependencies that are not installed. Also, I'm wanting to make an installer. Would that be okay?

jdev082 commented 2 years ago

An installer isn't needed, packages and binaries are easily available.

hello-smile6 commented 2 years ago

An installer isn't needed, packages and binaries are easily available.

Could I build binaries using https://npmjs.com/package/pkg ?

jdev082 commented 2 years ago

DEB64, RPM64, DEB32, RPM32, RPMARM64, DEBARM64, EXE, and *.app files can be created with the build system

npm run make
hello-smile6 commented 2 years ago

DEB64, RPM64, DEB32, RPM32, RPMARM64, DEBARM64, EXE, and *.app files can be created with the build system

npm run make

What about packaged copies of dev builds?

jdev082 commented 2 years ago

dev builds aren't priority for packaging.

hello-smile6 commented 2 years ago

dev builds aren't priority for packaging.

Oh.

hello-smile6 commented 2 years ago

@JaydenDev Just letting you know:

  1. Make the search bar and go button on same line

Any suggestions?

Item 1 is fixed by #16 (Yes, I added <!DOCTYPE html> again, but test it first)

jdev082 commented 2 years ago

The creator of the PR is required to test it, I don't want broken PRs being merged.

hello-smile6 commented 2 years ago

The creator of the PR is required to test it, I don't want broken PRs being merged.

I already tested it, but just don't want it ignored.

jdev082 commented 2 years ago

testing PR now.

jdev082 commented 2 years ago

Great UI, things are just wayyy too small

image

hello-smile6 commented 2 years ago

Great UI, things are just wayyy too small

image

Okay. I'll have a fix in 10 minutes, hopefully. I'll also add environment variables to make UI size changes easier.

jdev082 commented 2 years ago

Were you on a 1080p monitor?

hello-smile6 commented 2 years ago

Were you on a 1080p monitor?

Here's screen

Screen {availWidth: 1366, availHeight: 738, width: 1366, height: 768, colorDepth: 24, …}
availHeight: 738
availLeft: 0
availTop: 0
availWidth: 1366
colorDepth: 24
height: 768
orientation: ScreenOrientation
angle: 0
onchange: null
type: "landscape-primary"
[[Prototype]]: ScreenOrientation
pixelDepth: 24
width: 1366
[[Prototype]]: Screen
jdev082 commented 2 years ago

Did you make the UI small by preference, or monitor config

hello-smile6 commented 2 years ago

Did you make the UI small by preference, or monitor config

Preference. I like small menus.

jdev082 commented 2 years ago

Small menus can generally be bad, small UI = harder to read

hello-smile6 commented 2 years ago

Small menus can generally be bad, small UI = harder to read

Oh, I'll try to make it look better.

jdev082 commented 2 years ago

i think half the size of a firefox tab is good

hello-smile6 commented 2 years ago

i think half the size of a firefox tab is good

Okay, I'll install Firefox (or check the source) and try to add that.

jdev082 commented 2 years ago

image

hello-smile6 commented 2 years ago

image

That'd be 36px, I think.

jdev082 commented 2 years ago

half of the size?

hello-smile6 commented 2 years ago

half of the size?

18px. That's 2px less than my config.

jdev082 commented 2 years ago

image great so far

hello-smile6 commented 2 years ago

image great so far

Since env.css is in .gitignore, there should be a defaults.css loaded before it so the UI doesn't look weird.

jdev082 commented 2 years ago

image default config

hello-smile6 commented 2 years ago

Commenting from freecat! image

hello-smile6 commented 2 years ago

@JaydenDev Could you enable GitHub Discussions?

jdev082 commented 2 years ago

Yeah yeah, but discussions feels kinda bloated compared to the issues tab. Also more people are familiar with issues.

jdev082 commented 2 years ago

does freecat handle cookies properly? do you stay logged in?

hello-smile6 commented 2 years ago

does freecat handle cookies properly? do you stay logged in?

Not sure, I assume it wouldn't.

jdev082 commented 2 years ago

Ninetails does it just fine, which uses the same technologies almost

jdev082 commented 2 years ago

Would it be possible to implement a reload feature?

hello-smile6 commented 2 years ago

Yeah yeah, but discussions feels kinda bloated compared to the issues tab. Also more people are familiar with issues.

However, issues can quickly get off-topic. Also, it can get hard to decide when to close an issue that's more of a discussion. As an added reason, many websites related to github use the number of open issues to judge repository quality.

hello-smile6 commented 2 years ago

Would it be possible to implement a reload feature?

Probably. I'll look at it.

jdev082 commented 2 years ago

soo... more issues = better software? doesn't really make sense

hello-smile6 commented 2 years ago

soo... more issues = better software? doesn't really make sense

It's just a factor they might consider. Also, it gets frustrating when people open issues that are just to ask questions about something.

jdev082 commented 2 years ago

well this'll work for now, can't be puttin that much effort into a hobby project.

hello-smile6 commented 2 years ago

well this'll work for now, can't be puttin that much effort into a hobby project.

Why not? You just have to enable it in the repo settings, it takes less than 30 seconds. Also, this could go beyond a hobby project. Just look at https://beakerbrowser.org/ (another electron browser)

jdev082 commented 2 years ago

who's gonna use a browser with barely any features made by a kid?

hello-smile6 commented 2 years ago

who's gonna use a browser with barely any features made by a kid?

It doesn't have to stop there. How about this?

Who's going to use a browser with more features than Chromium that uses less memory, has bookmarklet APIs designed to allow full access to webpage contexts, and allows the JS stack, DOM, and element focus state to be saved to a file, and happens to be made by a kid?

Everyone. If you put the effort in, you'll get better results.

jdev082 commented 2 years ago

I put plenty of effort in, it is just a HTML UI with web views after all.

hello-smile6 commented 2 years ago

I put plenty of effort in, it is just a HTML UI with web views after all.

It can be more. And it should become more over time.