jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Discuss #12

Closed jdev082 closed 2 years ago

jdev082 commented 2 years ago
  1. Make the search bar and go button on same line

Any suggestions?

jdev082 commented 2 years ago

too many features people want

requested features: history

hard to implement

hello-smile6 commented 2 years ago

too many features people want

requested features: history

hard to implement

Think Electron webview API might help with that.

jdev082 commented 2 years ago

Might push history from 1.1 to 1.2 and just implement reloading and call it a day

hello-smile6 commented 2 years ago

Might push history from 1.1 to 1.2 and just implement reloading and call it a day

I think I got history, testing right now.

jdev082 commented 2 years ago

i could probobly just have a reload() function and have it reset the src part of the webview and have it reload

hello-smile6 commented 2 years ago

i could probobly just have a reload() function and have it reset the src part of the webview and have it reload

Or you could use the webview api.

jdev082 commented 2 years ago

my ways are easier, but irrelevant and complicated. APIs are hard

hello-smile6 commented 2 years ago

my ways are easier, but irrelevant and complicated. APIs are hard

I disagree. Reverse-engineering your own app is harder than just not rming your source,

jdev082 commented 2 years ago

It doesn't all have to be in electron, I can just write my own framework and combine them. Just kidding

hello-smile6 commented 2 years ago

It doesn't all have to be in electron, I can just write my own framework and combine them. Just kidding

I know how! Wait a moment.

jdev082 commented 2 years ago
function reload() {
    document.getElementById("view").src="";
    document.getElementById("view").src=wsite;
}
<button onClick="reload()">Reload Icon</button>
jdev082 commented 2 years ago

Only 5 lines of code

jdev082 commented 2 years ago
function reload() {
    document.getElementById("view").src=wsite;
}
<button onClick="reload()">Reload Icon</button>

shortened and optimized version

hello-smile6 commented 2 years ago
function reload() {
    document.getElementById("view").src=wsite;
}
<button onClick="reload()">Reload Icon</button>

shortened and optimized version

Or, addEventListener and you can get rid of that CSP warning.

jdev082 commented 2 years ago

uhh.. what's an addEventListener

hello-smile6 commented 2 years ago

uhh.. what's an addEventListener

domNode.addEventListener("click",function() {
  alert(1);
});
jdev082 commented 2 years ago

THAT... is better than BUTTONS? hah

jdev082 commented 2 years ago

buttons r kool

hello-smile6 commented 2 years ago

THAT... is better than BUTTONS? hah

Not better. Better than using onClick. Wait a moment and I'll make a demo.

jdev082 commented 2 years ago

nothing is better than the one and only onClick, where is the evidence

hello-smile6 commented 2 years ago

nothing is better than the one and only onClick, where is the evidence

image onclick requires unsafe-eval to be enabled. Want to remove that warning? addEventListener is the way.

jdev082 commented 2 years ago

I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen

hello-smile6 commented 2 years ago

I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen

Oh, I won't. I'll just implement it to show you. :)

hello-smile6 commented 2 years ago

I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen

Told you! https://github.com/JaydenDev/freecat/pull/20

jdev082 commented 2 years ago

your latest PR wont merge

hello-smile6 commented 2 years ago

your latest PR wont merge

I fixed it

jdev082 commented 2 years ago

time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools

hello-smile6 commented 2 years ago

time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools

I'll fix it.

hello-smile6 commented 2 years ago

time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools

Fixed by 19ed3fad0f0e15fa5c0417d21e7f471deac4cc4e

hello-smile6 commented 2 years ago

@JaydenDev Are you okay?

jdev082 commented 2 years ago

i was just playing terraria

jdev082 commented 2 years ago

custom about menu... possible?

hello-smile6 commented 2 years ago

i was just playing terraria

What's that? Have you tried Scratcharia? https://turbowarp.org/46587498/

hello-smile6 commented 2 years ago

custom about menu... possible?

I don't think so, unless custom implementations of everything in the title bar were made.

webdev03 commented 2 years ago

Why are there hidden rickrolls? 🤣

hello-smile6 commented 2 years ago

Why are there hidden rickrolls? 🤣

What do you mean? What commit?

webdev03 commented 2 years ago

Check in the main.js

hello-smile6 commented 2 years ago

Check in the main.js

Okay

webdev03 commented 2 years ago

Uncaught Exception: TypeError: app.whenReady is not a function

hello-smile6 commented 2 years ago

Don't see anything. main.js

hello-smile6 commented 2 years ago

Uncaught Exception: TypeError: app.whenReady is not a function

I see an error from my menu removal (Fixing right now), but nothing else. Run git pull

webdev03 commented 2 years ago

I fixed it

hello-smile6 commented 2 years ago

I fixed it

What commit added the problems?

webdev03 commented 2 years ago

I think that the whenReady doesn't exist (where did you even get that from), as well as when removing the menu there was still Menu.append(menu) even though menu doesn't exist (it was commented out)

hello-smile6 commented 2 years ago

I think that the whenReady doesn't exist (where did you even get that from), as well as when removing the menu there was still Menu.append(menu) even though menu doesn't exist (it was commented out)

Oh, it exists for me. Run npm update

webdev03 commented 2 years ago

Uncaught Exception: TypeError: mainWindow.loadFile is not a function

hello-smile6 commented 2 years ago

Uncaught Exception: TypeError: mainWindow.loadFile is not a function

I think that's my fault, working on it.

webdev03 commented 2 years ago

You sure?

hello-smile6 commented 2 years ago

It looks like it's real (used in dependencies). Not sure, looking into it.

webdev03 commented 2 years ago

I swear, I have

app.on('ready', () => {
    globalShortcut.register('CommandOrControl+C', () => {
      shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
    });
    globalShortcut.register("CommandOrControl+W", () => {
      shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
    });
  globalShortcut.register("CommandOrControl+Shift+Esc", () => {
    shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
  });
});

and it leads to a rickroll. @JaydenDev I'm confused why you're saying this doesn't exist, at least it was there in an earlier commit. I'm a bit tired and bored, see you