Closed jdev082 closed 2 years ago
too many features people want
requested features: history
hard to implement
too many features people want
requested features: history
hard to implement
Think Electron webview API might help with that.
Might push history from 1.1 to 1.2 and just implement reloading and call it a day
Might push history from 1.1 to 1.2 and just implement reloading and call it a day
I think I got history, testing right now.
i could probobly just have a reload() function and have it reset the src part of the webview and have it reload
i could probobly just have a reload() function and have it reset the src part of the webview and have it reload
Or you could use the webview api.
my ways are easier, but irrelevant and complicated. APIs are hard
my ways are easier, but irrelevant and complicated. APIs are hard
I disagree. Reverse-engineering your own app is harder than just not rm
ing your source,
It doesn't all have to be in electron, I can just write my own framework and combine them. Just kidding
It doesn't all have to be in electron, I can just write my own framework and combine them. Just kidding
I know how! Wait a moment.
function reload() {
document.getElementById("view").src="";
document.getElementById("view").src=wsite;
}
<button onClick="reload()">Reload Icon</button>
Only 5 lines of code
function reload() {
document.getElementById("view").src=wsite;
}
<button onClick="reload()">Reload Icon</button>
shortened and optimized version
function reload() { document.getElementById("view").src=wsite; }
<button onClick="reload()">Reload Icon</button>
shortened and optimized version
Or, addEventListener
and you can get rid of that CSP warning.
uhh.. what's an addEventListener
uhh.. what's an addEventListener
domNode.addEventListener("click",function() {
alert(1);
});
THAT... is better than BUTTONS? hah
buttons r kool
THAT... is better than BUTTONS? hah
Not better. Better than using onClick. Wait a moment and I'll make a demo.
nothing is better than the one and only onClick, where is the evidence
nothing is better than the one and only onClick, where is the evidence
onclick requires unsafe-eval to be enabled. Want to remove that warning? addEventListener
is the way.
I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen
I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen
Oh, I won't. I'll just implement it to show you. :)
I have to go, I'll be back. Get some clear evidence, and explain some differences between event listeners and onClick. Once it is decided whatever better one will be chosen
your latest PR wont merge
your latest PR wont merge
I fixed it
time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools
time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools
I'll fix it.
time to sort out who removed all those window titlebar options. Some important features were removed: Full screen Developer Tools
Fixed by 19ed3fad0f0e15fa5c0417d21e7f471deac4cc4e
@JaydenDev Are you okay?
i was just playing terraria
custom about menu... possible?
i was just playing terraria
What's that? Have you tried Scratcharia? https://turbowarp.org/46587498/
custom about menu... possible?
I don't think so, unless custom implementations of everything in the title bar were made.
Why are there hidden rickrolls? 🤣
Why are there hidden rickrolls? 🤣
What do you mean? What commit?
Check in the main.js
Check in the main.js
Okay
Uncaught Exception: TypeError: app.whenReady is not a function
Don't see anything. main.js
Uncaught Exception: TypeError: app.whenReady is not a function
I see an error from my menu removal (Fixing right now), but nothing else. Run git pull
I fixed it
I fixed it
What commit added the problems?
I think that the whenReady doesn't exist (where did you even get that from), as well as when removing the menu there was still
Menu.append(menu)
even though menu
doesn't exist (it was commented out)
I think that the whenReady doesn't exist (where did you even get that from), as well as when removing the menu there was still
Menu.append(menu)
even thoughmenu
doesn't exist (it was commented out)
Oh, it exists for me. Run npm update
Uncaught Exception: TypeError: mainWindow.loadFile is not a function
Uncaught Exception: TypeError: mainWindow.loadFile is not a function
I think that's my fault, working on it.
You sure?
It looks like it's real (used in dependencies). Not sure, looking into it.
I swear, I have
app.on('ready', () => {
globalShortcut.register('CommandOrControl+C', () => {
shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
});
globalShortcut.register("CommandOrControl+W", () => {
shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
});
globalShortcut.register("CommandOrControl+Shift+Esc", () => {
shell.openExternal("https://youtu.be/dQw4w9WgXcQ");
});
});
and it leads to a rickroll. @JaydenDev I'm confused why you're saying this doesn't exist, at least it was there in an earlier commit. I'm a bit tired and bored, see you
Any suggestions?