Open dosumis opened 9 years ago
No.
We could do this if
I've discussed point 2 with @ajdm but no telling if this will be possible.
If I've understood correctly, this could also be done if we can get #20 to work (which I'd forgotten about, to be honest). At the moment, we can have links to pre-fill fields, but not autocomplete on the same fields, although this might be possible if we implement a different autocompletion mechanism. I'll investigate on a different branch.
Quick way to get a webservice: open up post requests on the form ??
Now implemented with #54, merged into master and deployed to flybrain. For example, clicking on http://flybrain.mrc-lmb.cam.ac.uk/si/nblast/on-the-fly/#query_all=fru-M-500112 and then clicking the NBLAST button should give the NBLAST results, as well as the links to VFB implemented in #53.
@dosumis @Robbie1977 @mmc46 Could we implement a link out scheme from all flycircuit neurons on VFB using this url pattern
http://flybrain.mrc-lmb.cam.ac.uk/si/nblast/on-the-fly/#query_all=<fc_neuron_id>
``
OK. Already using idid for linkouts to flycircuit, so should be straightforward.
Just to confirm, these links still work irrespective of whether the code is running on flybrain or the external VPS, so should remain stable.
This still works after the rewrite.
can we turn on mean scores in the link?
@ajdm do you know?
can we turn on mean scores in the link?
would we have to just turn mean scores on by default?
I looked at this code: https://github.com/jefferislab/NBLAST_on-the-fly/blob/master/url.js and it looks like it should be possible to update checkboxes, but haven't worked out the syntax.
I can do it, but this has revealed a bug in the current implementation. Will fix and push soon.
Done in 7b711b3875970d7ba062d4249da4ade55094d8d1. I've had to remove the example field input and have put it in the text, as this causes the wrong scores to be loaded on page load from a link to a different neuron.
I've had to remove the example field input and have put it in the text, as this causes the wrong scores to be loaded on page load from a link to a different neuron.
Thanks! I think that's fine. G.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.
That sounds great @ajdm. Is this update live?
I am trying:
http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#query_all=fru-M-500112,all_use_mean=TRUE
and it is searching for the default value (fru-M-200266) as suggested in your earlier message.
Sorry, I forgot to update flybrain. Live now.
Hmm. Right now
http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#query_all=fru-M-500112,all_use_mean=TRUE
sets the checkbox but doesn't choose a neuron or run a search. Consistent with this:
http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#query_all=fru-M-500112
no longer works for me, but just results in an empty search. Finally
http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#all_use_mean=TRUE
does set the checkbox but of course does not run a search. Am I missing something @ajdm?
Getting it to run a search without it ever running the wrong search seems to be impossible, as the output can only be reactive on one input, not both. This means that if you have a URL that contains a neuron ID and a checkbox option it will run the search before setting the checkbox. As such, it just prefills the inputs and waits for the user to press the button.
Hmm OK. I get this bit:
As such, it just prefills the inputs and waits for the user to press the button.
But for the urls mentioned above, for me, it doesn't put neuron id in the id field (and pressing the button therefore does nothing!)
Ah. During the rewrite I renamed query_all
to all_query
to make the code more consistent. http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#all_query=fru-M-500112,all_use_mean=TRUE should work for your first link. Do you want me to change this back to query_all
, or change the links?
Ah! That's fine. We can go with the revised url scheme. Maybe you can add some information to the README documenting the url scheme. Also could you add the same functionality for the GAL4 search?
Also could you add the same functionality for the GAL4 search? +1 - this is what we'd most like for VFB linkouts.
@ajdm Any chance you could take a look at the GAL4 linkout?
Sorry, I meant to reply earlier but obviously didn't get around to it. The problem with the GAL4 linkout is that you don't seem to be able to get it to change to the GAL4 tab. I keep on having a few more ideas on how to try it but none have worked so far. I'll let you know if I get anywhere.
Ah, I see. That's a pain, because after the paper and the chaps at VFB advertising, this is something that loads of people are interested in.
As a very un-ideal solution, we could spin off the GAL4 search into a separate Shiny app and have a link to and from the main one there. Then I could set up the URL-linking as I did for the one-against-all search.
What would be the downsides other than different urls?
As far as I can tell, the only other downside is the lack of state sharing. At the moment, if you switch between tabs, your previous input is remembered. If we had separate apps, that wouldn't be the case if people closed their browser tab. Also, as far as I can find, there's no way to stop it opening a new tab if that page is already open in a browser tab, so you wouldn't 'switch' between tabs in the same way as you currently do.
Might this be useful? https://github.com/aoles/shinyURL
I've now got this working in 797f010deddfb3b9bed9574feb57d3c86303ac52 and it seems to work well, but I can't get packrat
to add the shinyURL
package into the version store. Any ideas? (packrat::snapshot()
doesn't work)
I've now got this working in 797f010 and it seems to work well,
Super!
but I can't get packrat to add the shinyURL package into the version store. Any ideas? (packrat::snapshot() doesn't work)
What does the error look like?
There's no error, it just doesn't add anything.
Are you doing this on your laptop or live on flybrain? Do you have latest R? How was the shinyURL package installed? I assume by devtools::install_github
.
Laptop. I could just install the package on flybrain, but that would somewhat defeat the point of using packrat. I'm on R 3.2.3, and installed the shinyURL package as you said.
I'll take a look quickly on my laptop, but I would recommend installing shinyURL manually for the time being.
Now running on flybrain. GAL4 links have the format of http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/?gal4_query=fru-M-200266&tab=GAL4.
woot! or words to that effect!
@dosumis do you want to try this out? Worked for me.
Excellent. Works fine for me (although feels a bit odd that I still need to press the NBlast button).
@Robbie1977 - can we make it a priority to get these added?
I guess this issue is identifying the appropriate individuals to add to. This could potentially be hacked into the current site based on the image being from the FlyCircuit dataset. We should be able to add on VFBdev version of 1.5 based on typing of individuals in Neo as neuron. Code in place, but rebuild of Neo production required.
Neither: http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#query_all=fru-M-500112,all_use_mean=TRUE or http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/#all_query=fru-M-500112,all_use_mean=TRUE seems to show any results now?
GAL4 is working (with user NBLAST button press).
http://flybrain.mrc-lmb.cam.ac.uk:8080/NBLAST_on-the-fly/?all_query=fru-M-500112&all_use_mean=TRUE is the new format. Sorry for not making the change clearer.
thanks
Is is possible to roll a stable link to a 1 against all Nblast?
I'd like to use this to roll links from single neuron pages on VFB to NBlast.