Nullable int Id in TMDbLib.Objects.TvShows.TvEpisodeInfo

jellyfin / TMDbLib

C#.Net library for TheMovieDB

MIT License

344 stars 128 forks source link

Nullable int Id in TMDbLib.Objects.TvShows.TvEpisodeInfo #376

Open WolfgangRoggen opened 3 years ago

WolfgangRoggen commented 3 years ago

You made the property: TMDbLib.Objects.TvShows.TvEpisodeInfo.Id nullable. This seems not correct. In my understanding the Id cant be null. Same for: TMDbLib.Objects.TvShows.TvSeason.Id

Please have a look ainto the description of the Api. Episode and Season have 2 Id's one "string _id" and one "int id" (see underscore)

And afaik you have no Property for the string _id.

Regards Wolfgang

LordMike commented 3 years ago

The missing _id is definitely a bug. But as for the nullable int - there is a risk that this may be because the object is used in two places. It may be that the other place doesn't provide an id.