jellyfin / TMDbLib

C#.Net library for TheMovieDB
MIT License
344 stars 128 forks source link

Updated TranslationData model #408

Closed Almis90 closed 1 year ago

Almis90 commented 2 years ago

Replaced name with title Added runtime

Almis90 commented 2 years ago

This is an urgent pull request because right now there is no other way to get translated titles.

LordMike commented 2 years ago

Ah, so I see that Movie and Tv have different translation datas, your change will break it for movies, which still use "title" - while Tv will use "name".

LordMike commented 2 years ago

@Almis90 could you try out this branch on the tv show you're looking at? It should fill out Name with the title from the response

LordMike commented 2 years ago

Also - I can't identify any translation datas with "runtime" in them, can you confirm its a property that exists somewhere?

Almis90 commented 2 years ago

Check this url https://api.themoviedb.org/3/movie/818397/translations?api_key={api_key}

Almis90 commented 2 years ago

@Almis90 could you try out this branch on the tv show you're looking at? It should fill out Name with the title from the response

Yes, it's working, but I tested only movies not tv-shows, the hack worked :)

LordMike commented 2 years ago

Could you check the runtime thing I asked about?

Almis90 commented 2 years ago

Check this url https://api.themoviedb.org/3/movie/818397/translations?api_key={api_key}

I did check the result in above url

vindberg commented 1 year ago

Hi, good work. When will this be commited in the master? @LordMike can you push it out as a nuget also?

Thanks.

LordMike commented 1 year ago

I'll try to see if I can push this. In the meantime, you should be able to use the package registry in this Github repo - all CI builds should end up there.

Mike.


From: Anders @.> Sent: Tuesday, August 23, 2022 15:39 To: LordMike/TMDbLib @.> Cc: Michael Bisbjerg @.>; Mention @.> Subject: Re: [LordMike/TMDbLib] Updated TranslationData model (PR #408)

Hi, good work. When will this be commited in the master? @LordMikehttps://github.com/LordMike can you push it out as a nuget also?

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/LordMike/TMDbLib/pull/408#issuecomment-1224092752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH2YJ2WDEGTDWP6KQLNJE3V2TIC3ANCNFSM5X5TRWRA. You are receiving this because you were mentioned.Message ID: @.***>

vindberg commented 1 year ago

Thanks.

Im not able to find a nuget package from the fork or in the Actions section... so hoping this can be pushed out :)

LordMike commented 1 year ago

https://github.com/LordMike/TMDbLib/packages/691970

I made a short post on consuming it here: https://blog.mbwarez.dk/consuming-my-nuget-packages-from-github/

LordMike commented 1 year ago

Ooh - sorry, I completely missed that this is a PR - I was looking at mails and thought it was an issue.

LordMike commented 1 year ago

A new package should arrive at the feed I linked at, shortly.. :)

vindberg commented 1 year ago

Thanks, appreciate it.