jellyfin / TMDbLib

C#.Net library for TheMovieDB
MIT License
344 stars 128 forks source link

Extend MediaType #435

Closed angyanmark closed 9 months ago

angyanmark commented 1 year ago

Fixes: #414, #415, #420, #430

This will do the trick, but it would be nicer if we could map two different enum values to the same enum. Like this:

[EnumValue("episode")]
[EnumValue("tv_episode")]
Episode = 4,

or

[EnumValue("episode", "tv_episode")]
Episode = 4,
LordMike commented 1 year ago

Would one of you be interested in maintaining this library?

I'm no longer using TMDb, so it's a chore. :/

angyanmark commented 1 year ago

I think the current pull requests can be accepted, they contain a lot of features and bug fixes. I don't plan on using the library anymore either.

cvium commented 10 months ago

Would one of you be interested in maintaining this library?

I'm no longer using TMDb, so it's a chore. :/

@LordMike Hey. We've used your library for a while in Jellyfin and we might be willing to take over. Would you be willing to transfer the repo to us? Or would you prefer a fork?

LordMike commented 10 months ago

I could transfer it. I think that makes most sense.

Would this work?

cvium commented 10 months ago

Yes, that works for us.

jakelandau commented 9 months ago

Are there any updates on the transfer of package maintenance to the Jellyfin project? As a downstream consumer of this package I haven't heard of any news in the Jellyfin #development channel on the discord server.

LordMike commented 9 months ago

I added @cvium as a member to this repo a few days ago - I do hope he got an email :P

I couldn't transfer the repo myself because of rights.

LordMike commented 9 months ago

I just checked - the invite was expired. I've reinvited.

cvium commented 9 months ago

Yes, sorry, I keep forgetting

cvium commented 9 months ago

@LordMike I think you need to give me permissions to transfer

LordMike commented 9 months ago

@cvium ok - so I think that for personal projects like this, there can be only one admin. At least, all the pictures I can find indicate a drop down for role, but its simply not present.

What I can do is transfer the project to you (which I can't because you already have a project named TMDbLib - delete that) and then you will be an admin. Or I can become an admin in Jellyfin and then have the permission to create projects there (which is required to do transfers).

Let me know.

cvium commented 9 months ago

@LordMike I have deleted my fork. I can't give you admin in Jellyfin. Even I'm not an admin there :)

LordMike commented 9 months ago

@cvium check your .. something .. there should be a transfer request.

LordMike commented 9 months ago

Aand, now it is at Jellyfin. Good job everyone! :)

cvium commented 9 months ago

The roundabout transfer is complete: https://github.com/jellyfin/TMDbLib. Unfortunately, our GH admin is asleep, so your permissions will be set up later

LordMike commented 9 months ago

We also need to transfer the NuGet package ownership. @cvium

cvium commented 9 months ago

We also need to transfer the NuGet package ownership. @cvium

I think we need @anthonylavado for that

Bond-009 commented 9 months ago

Isn't that just adding Jellyfin as an owner of the package? https://www.nuget.org/profiles/Jellyfin (TMDbLib > Manage Package > Owners)

LordMike commented 9 months ago

I have added jellyfin. There should be request awaiting approval somewhere.

LordMike commented 9 months ago

Well. It was accepted. I assume all is good and I can remove myself from the package?