search

jenkinsci / hipchat-plugin

HipChat notification plugin for Jenkins
https://plugins.jenkins.io/hipchat/
54 stars 85 forks source link

room setting and notification selection should be per post-build task, not per build #29

Closed jikamens closed 9 years ago

jikamens commented 9 years ago

Right now there's a HipChat configuration setting in each build, where you specify the room (to override the default) and which notifications to send, regardless of whether the HipChat post-build action is enabled for the build.

This configuration should be per-post-build-action, not per-build, for two reasons:

  1. It is quite misleading to have that configuration at the top of the build configuration page when it doesn't actually do anything unless there is a HipChat post-build action configured for the build.
  2. Putting the config per-action rather than per-build would allow different types of notifications to be sent to different rooms.
aldaris commented 9 years ago

I believe this is already resolved with bb103a3.

aldaris commented 9 years ago

Feel free to check out the latest nightly, should work much better.