search

jenkinsci / hipchat-plugin

HipChat notification plugin for Jenkins
https://plugins.jenkins.io/hipchat/
54 stars 85 forks source link

Silence from Hipchat plugin on likely failures #46

Closed TimGebhardt closed 9 years ago

TimGebhardt commented 9 years ago

Hello, I just ran into an issue where I configured the Hipchat plugin on Jenkins and things were silently failing. I didn't know if the plugin was working or not, but eventually I hooked up verbose logging and discovered that the user I was sending as was more than 15 characters.

My request is to output likely failure messages to the build log.

aldaris commented 9 years ago

Looks like this is a limitation of the v1 API: https://www.hipchat.com/docs/api/method/rooms/message I think it would be helpful if the config screen could warn about invalid value. To improve the error messages probably I'll work on #9 instead.

aldaris commented 9 years ago

FYI #9 is now resolved, so firstly the build log should now indicate if sending the notification has failed, but more importantly the Test Notification button now properly displays error messages.

aldaris commented 9 years ago

The UI is now a lot more friendlier and provides useful error messages when send As value is incorrect/missing. see 515bb96