Enable TLSv1.1/2 for HttpClient

jenkinsci / hipchat-plugin

HipChat notification plugin for Jenkins

https://plugins.jenkins.io/hipchat/

54 stars 85 forks source link

Enable TLSv1.1/2 for HttpClient #49

Closed drewdogg closed 9 years ago

drewdogg commented 9 years ago

We just moved to a private HipChat server within my company. They set it up with TLSv1.2 only for secure connections. However, Java 7 does not have it enabled by default. I found an example online on how to enable it: https://discretemkt.wordpress.com/2014/11/16/commons-httpclient-can-disable-sslv3/. I figured other users of this plugin might also need this protocol enabled.

aldaris commented 9 years ago

Thanks for the PR, this is now resolved with 7c51731, which upgraded http-client to 4.5 and customizing SSLConnectionSocketFactory instead.

drewdogg commented 9 years ago

@aldaris Awesomesauce!