jenkinsci / hipchat-plugin

HipChat notification plugin for Jenkins
https://plugins.jenkins.io/hipchat/
54 stars 85 forks source link

Success messages not populating #83

Closed Fyb3roptik closed 7 years ago

Fyb3roptik commented 8 years ago

I have build starting and build failed showing in my chatroom just fine, but success does not work. Not sure why as it is set just like the others, but no matter what I try it does not work.

Fyb3roptik commented 8 years ago

I should note I am using the AWS Beanstalk plugin as well to zip up my repo and submit it to AWS BS

willpracht commented 8 years ago

I'm also seeing this behavior, but not only the success notification, but the unstable as well.

Failure seems to work just fine though.

aldaris commented 8 years ago

Plugin version? Screenshot of config? What kind of job type did you use? Or do you have any reproduction steps at all?

willpracht commented 8 years ago

Sorry about that! :)

2016-09-27_1625
willpracht commented 8 years ago

@aldaris

Ah! I think I figured out my problem.

"The default notifications listed here will be used when a given project does not specify which events should trigger HipChat notifications."

So am I to believe that the global configuration is only to set the templates (aside from the default notification)?

And then each job will have to set the notifications for themselves?

Wish I could set the global notification for all projects one time for uniformity. :(

aldaris commented 8 years ago

IIRC the default notifications will be used only when the job does not specify any notification on its own. If you have defined a single notification at the job level, the default notification configuration will no longer apply.

willpracht commented 8 years ago

Ah, okay. And you can only set ONE default notification globally, it seems.

That really throws a wrench into the works :(.

aldaris commented 8 years ago

Nope, you should be able to have as many default notifications as you want. Assuming that there are no notifications defined at the job level, all default notifications should apply for the job.

willpracht commented 8 years ago

@aldaris

OOOOH. Hold on. I wasn't understanding quite right. Let me remove the notifications action from the job. I bet that fixes it. ;p

I was for whatever reason assuming that adding the action, but not creating any notifications would be the same as not having the action. I am so dumb. ;)

willpracht commented 8 years ago

Well, maybe not.

New setup was to add the global notifications back in, remove the HipChat notification post-build action completely.

That resulted in zero notifications for my job, either success or failure.

aldaris commented 8 years ago

You still need the post build action on the job, otherwise the plugin will never be invoked. Just don't add any notifications to the post build task config at the job level.

willpracht commented 8 years ago

@aldaris

Yeah, that's what I had setup before. Unfortunately that was when I was just getting the failure notification.

willpracht commented 8 years ago

If I add a success notification to the job itself, don't configure anything with it, then it will actually trigger the notification.

This is kind of rough, but seems to be the norm with Jenkins plugins:

willpracht commented 8 years ago

@aldaris

Anyway, I appreciate the help with this. Probably just going to live with the individual configuration for now, do some more research.

Thanks!

aldaris commented 8 years ago

global job Have configured my jobs as pics above and I am getting the notifications just fine.

This also means that success notifications are also working for me I'm afraid. Can you provide a minimum set of reproduction steps that always results in this behavior?

aldaris commented 7 years ago

Sorry guys, but I'm not able to reproduce this, closing until there is a reliable way to reproduce this.

johnyod commented 7 years ago

Hi -- How do i send the jenkins output file (csv) attachment to a particular hipchat room via this plug-in..