search

jensstein / oandbackup

backup manager for android
Other
544 stars 193 forks source link

Create strings.xml #151

Open liveasx opened 7 years ago

jensstein commented 7 years ago

hi, thanks a lot for your contributions :) to make the translation work, you need to move strings.xml into values-zh-rCN. also, could i get you to be a little more descriptive in your commit messages? mentioning that you update strings.xml for chinese would be nice. and lastly: i really appreciate your work and it will be merged as soon as strings.xml is in the right directory, but translation work is probably best done via transifex.

thanks again :)

liveasx commented 7 years ago

You did not give me transifex permission, i can only submit here in Github

jensstein commented 7 years ago

i'm so sorry, i don't know how i missed that. you should have permissions now. but i think it's easier if we do the first import of the translation through git.

the only problem right now is that your changes don't compile. res/values-zh-rCN/strings.xml:L.101 has apostrophes which are not escaped. they need to be written as \' (i would do it myself, but i think it's best that you do it since i can't read the context they are in).