search

jeremyschuurmans / roman-numeral-converter-project

This learning project will expand a roman numeral converter to be a command line tool and eventually an API endpoint.
1 stars 0 forks source link

Resolve dependency #6

Closed jeremyschuurmans closed 4 years ago

jeremyschuurmans commented 4 years ago

In the Application class, there was a dependency on the Converter class that violated the Open/Closed principle. This PR attempts to resolve the dependency by injection, making the program more extensible. I don't 100% understand dependency injection yet, so definitely let me know if I'm on the right track in how I'm thinking about this.

mikeknep commented 4 years ago

You're on the right track here! But what if I wanted to use a different converter that converted the roman numeral to the number spelled out in English (ex. "eighteen")?

pedmiston commented 4 years ago

Resolved by PR https://github.com/palledorous/roman-numeral-converter-project/pull/5