search

jeromeetienne / threejs-inspector

chrome devtool extension to debug three.js
https://chrome.google.com/webstore/detail/threejs-inspector/dnhjfclbfhcbcdfpjaeacomhbdfjbebi
200 stars 45 forks source link

Injected script breaks console.log for everything else on page. #17

Closed martikaljuve closed 8 years ago

martikaljuve commented 8 years ago

Since the scripts are injected into the current page, console.log is disabled for every other script running on the page as well, which is not very desirable.

https://github.com/jeromeetienne/threejs-inspector/blob/38a2505fc1e166d9853b41c6b417687786332c48/src/panel/inspected-win/00-inspected-win-prefix.js#L52

snovak commented 8 years ago

This was killing me!. Please fix. Took the better part of an afternoon to realize what had happened.

jeromeetienne commented 8 years ago

Sorry about the delay, I fixed it in the .12 version

On Fri, Sep 2, 2016, 4:23 AM Sean Novak notifications@github.com wrote:

This was killing me!. Please fix. Took the better part of an afternoon to realize what had happened.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jeromeetienne/threejs-inspector/issues/17#issuecomment-244350082, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPcIjcp-EUu17LMWFzW4NnR6DFA5p4Oks5qmAcwgaJpZM4Jvgy2 .

jeromeetienne commented 8 years ago

https://github.com/jeromeetienne/threejs-inspector/blob/cb2cf92accb3fb921e260e50c2c662c10312b8ae/src/panel/inspected-win/00-inspected-win-prefix.js#L51 here is the change