Argon is a clean and tidy OpenWrt LuCI theme that allows users to customize their login interface with images or videos. It also supports automatic and manual switching between light and dark modes.
I noticed in a recent commit you added polyfill.min.js to the repository. That makes little sense, hotlinking it to the cdn has the advantage that the served JS file is based on the user-agent declared by the requesting browser.
If you just download it, it will be a plain empty file, without polyfills. At that point, you might as well drop it.
Correct solution if you want to support browser compatibility would be to download the npm package with the full polyfill logic based on the browser and load that one.
jerrykuku
commented
3 years ago
Greetings,
I noticed in a recent commit you added polyfill.min.js to the repository. That makes little sense, hotlinking it to the cdn has the advantage that the served JS file is based on the user-agent declared by the requesting browser.
If you just download it, it will be a plain empty file, without polyfills. At that point, you might as well drop it.
Correct solution if you want to support browser compatibility would be to download the npm package with the full polyfill logic based on the browser and load that one.