search

jerrykuku / luci-theme-argon

Argon is a clean and tidy OpenWrt LuCI theme that allows users to customize their login interface with images or videos. It also supports automatic and manual switching between light and dark modes.
Apache License 2.0
4.09k stars 800 forks source link

v2.2.9.4 release changes package name #387

Closed TheRealGramdalf closed 1 year ago

TheRealGramdalf commented 1 year ago

Describe the bug As of the v2.2.9.4 release, the package name changed from luci-theme-argon to luci-theme-argon-master. This breaks scripts such as okibcn's image builder script, and makes a lot of the information available online incorrect.

To Reproduce Steps to reproduce the behavior:

Expected behavior

Screenshots If applicable, add screenshots to help explain your problem. luci-theme-argon-master_2.2.9.4_all.ipk/control.tar.gz/control (Bugged version - v2.2.9.4) image luci-theme-argon_2.2.9-20211016-1_all.ipk/control.tar.gz/control (What it should be - v2.2.9) image

Openwrt (please complete the following information): N/A

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context Add any other context about the problem here.

I believe this may be caused by the name of the folder the git repository was cloned into being named luci-theme-argon-master, referring to the master branch here on github. Make sure the repository is cloned into the correct directory (and is named correctly). I think it would be a good idea to release a new package that solves this problem, and remove the old entry (or mark it as buggy) from the github releases page.

jerrykuku commented 1 year ago

Sorry, it was a build error, I will update the correct package as soon as possible, meanwhile v2.3 has been released, you can wait for the latest version.