Argon 2.3.1 on OpenWrt 23.05.3 - Browser Website Appearance Settings Override Argon Theme Mode Configuration (Light Mode / Dark Mode)

jerrykuku / luci-theme-argon

Argon is a clean and tidy OpenWrt LuCI theme that allows users to customize their login interface with images or videos. It also supports automatic and manual switching between light and dark modes.

Apache License 2.0

3.85k stars 773 forks source link

Argon 2.3.1 on OpenWrt 23.05.3 - Browser Website Appearance Settings Override Argon Theme Mode Configuration (Light Mode / Dark Mode) #500

Open boktai1000 opened 2 months ago

boktai1000 commented 2 months ago

Describe the bug When configuring Light Mode in Argon config, when using Firefox browser the web interface will stay in dark mode. Using another browser such as Chrome will properly show Light Mode.

To Reproduce Steps to reproduce the behavior:

Use Mozilla Firefox
Configure Theme mode to Light Mode
Observe that the background does not change, and confirm against another browser.

Expected behavior Light Mode would be present

Screenshots If applicable, add screenshots to help explain your problem. Example here:

Openwrt (please complete the following information):

Versiosn: 23.05.3
Theme: Argon (manually installed via Snapshot, and fantastic-builds repository)
Version: 2.3.1

Desktop (please complete the following information):

OS: Windows
Browser: Firefox
Version: Windows 10, Firefox Latest (126)

Additional context Add any other context about the problem here.

qingtian110 commented 2 months ago

it works!

boktai1000 commented 2 months ago

I have some more data to report.

The issue also occurs for me on Microsoft Edge on Windows 10 x64 The issue does not occur for me with Google Chrome on Windows 10 x64 The issue does not occur for me on Microsoft Edge through a fresh Hyper-V VM for Windows 11

I have tried disabling all extensions (ublock origin and bitwarden) and loading the page as well as a full cache clean to no avail.

My primary computer that I'm reporting the issue through is Windows 10 x64 - latest updates - and my color settings are as follows (although I've obviously tried setting Light Mode, but tried messing with app/window mode default to see if that might trigger something - nada)

Thank you for posting a working image, clearly there is something more going on than meets the eye

boktai1000 commented 2 months ago

Update - I did some Googling and came across this:

Firefox - Website appearance set to Dark - about:preferences#searchResults

Edge - https://www.reddit.com/r/MicrosoftEdge/comments/1ayyiu6/stuck_in_dark_mode_how_do_i_turn_it_off/ - edge://settings/?search=dark

I can confirm that setting either of these options to System Default/Automatic will "fix" this or work as expected, but hear me out as I still believe there is an issue here.

I think this is still a bug though, because I would expect Argon/LuCI to be able to override this through the configuration, and it doesn't seem possible. I've never really encountered a situation like this before, but I'm happy I found out what's causing it now.