search

jetstack / terraform-google-gke-cluster

A Terraform module to create a best-practise Google Kubernetes Engine (GKE) cluster.
Apache License 2.0
161 stars 87 forks source link

Node version flag docs and auto_upgrade override #71

Closed wwwil closed 4 years ago

wwwil commented 4 years ago

This is a follow up PR to #67 that adds documentation to for the version option in the node_pool configuration. It also forces the management_auto_upgrade to false if a version is set to prevent the two options from fighting as described in the Terraform docs:

The Kubernetes version for the nodes in this pool. Note that if this field and auto_upgrade are both specified, they will fight each other for what the node version should be, so setting both is highly discouraged.

https://www.terraform.io/docs/providers/google/r/container_node_pool.html#version

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittermandel, wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/terraform-google-gke-cluster/blob/master/OWNERS)~~ [wwwil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
repo-lockdown[bot] commented 4 years ago

This project is now deprecated so we aren't accepting any further changes.