search

jetstack / terraform-google-gke-cluster

A Terraform module to create a best-practise Google Kubernetes Engine (GKE) cluster.
Apache License 2.0
161 stars 87 forks source link

add istio_config addons to the gke module #78

Closed Romain7495 closed 4 years ago

Romain7495 commented 4 years ago

Hi,

I am creating this PR to add the ability to configure istio beta feature in this module. I have created this PR after reading this issue #33

Best regards

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Romain7495 To complete the pull request process, please assign wwwil You can assign the PR to them by writing /assign @wwwil in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jetstack/terraform-google-gke-cluster/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jetstack-bot commented 4 years ago

Hi @Romain7495. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Romain7495 commented 4 years ago

/assign @wwwil

wwwil commented 4 years ago

Hi @Romain7495!

I'm afraid this module is now deprecated so we aren't accepting any further changes. Sorry if this wasn't clearer, the repo will be archived soon so that it's read only.

I would also now recommend installing Istio using istioctl as it offers more customisation options, rather than using this GKE Isito addon.

repo-lockdown[bot] commented 4 years ago

This project is now deprecated so we aren't accepting any further changes.