jfmonteil / Pentaho-Google-Sheet-Plugin

Pentaho Google Sheet Plugin (API V4)
20 stars 17 forks source link

"Append to sheet" setting not saved #4

Closed smalos closed 4 years ago

smalos commented 4 years ago

If I tick "Append to sheet" and click on "OK", the checkbox is unticked when I open the output dialog again.

If both "Append to sheet" and "Create new sheet if it does not exist" are ticked, the settings are saved.

If just "Create new sheet if it does not exist" is ticked, "Append to sheet" is ticked too when I open the dialog again.

jfmonteil commented 4 years ago

Thanks you, Let me check this today

jfmonteil commented 4 years ago

Thank you ! I had left a gross bug behind. I apologize for the numerous fixes before having a clean version. 4.1 should solve the problem. Than you again for your perseverance.

smalos commented 4 years ago

Thanks, that fixed it!

Just a question regarding PentahoGoogleSheetsPlugin-4.1-distribution.zip : The archive contains both PentahoGoogleSheetsPlugin-4.0.jar and PentahoGoogleSheetsPlugin-4.1.jar. I assume PentahoGoogleSheetsPlugin-4.0.jar can be removed.

jfmonteil commented 4 years ago

yes I have cleaned the zip ;)