search

jieter / Leaflet-semicircle

Extend Leaflet's circle class to display semicircles.
http://jieter.github.io/Leaflet-semicircle/examples/semicircle.html
MIT License
121 stars 52 forks source link

Object doesn't support property or method 'isSemicircle' #20

Closed ivleth closed 7 years ago

ivleth commented 7 years ago

Hi, Semicircle is broken by using leaflet 1.1.0 (http://cdn.leafletjs.com/leaflet/v1.1.0/leaflet-src.js) See your test page semicircle.html

Error: Object doesn't support property or method 'isSemicircle' Semicircle.js (125,13)

L.SVG.include({ _updateCircle: function (layer) { // If we want a circle, we use the original function if (!layer.isSemicircle()) { return _updateCircleSVG.call(this, layer); } ... etc etc

jieter commented 7 years ago

Thanks for reporting. Are you able to create a PR fixing this?

ivleth commented 7 years ago

Hi, I tried but I didn't get it fixed. Something is breaking in 1.1.0 compared 1.0.2

jieter commented 7 years ago

Does this help? https://github.com/jieter/Leaflet-semicircle/pull/17

ivleth commented 7 years ago

unfortunately it doesn't, same error...

jieter commented 7 years ago

should be fixed by fdb647e, released leaflet-semicircle@2.0.0