CircleMarker compatibility ?

[buchanan-fh]

When loading Semicircle.js on a map that already exists and uses CircleMarkers I get the following error : Semicircle.js:147 Uncaught TypeError: layer.startAngle is not a function

It seems that the Circle.extend part of the code doesn't apply to CircleMarkers

[jieter]

hmm, the order of inheritance changed in leaflet 1.0.0, which I assume you are using?

Should be fixed, you're welcome to make a patch and open a PR.

[buchanan-fh]

Yes I do use Leaflet 1.0.0 latest RC. Unfortunately I don't have sufficient knowledges and a good enough understanding of Leaflet code structure to submit a PR, but would be happy to do some tests.

[jieter]

Can you post a minimal example of the problem occurring?

[buchanan-fh]

I modified the fullcircle.html example located in your release this way, with a circleMarker that is supposed to be located just next to the circle :

<script>
    var latlng = [50.6, -0.0];
    var map = L.map('map').setView(latlng, 11);

    var radius = 500;

    L.circleMarker([50.61, -0.0]).addTo(map);

    L.circle(latlng, radius, {
        fill: true,
        fillColor:'#a1ba03',
        fillOpacity: 0.5,
        color: '#a1ba03',
        opacity: 0.5,
        startAngle: 0,
        stopAngle: 360
    }).addTo(map);

    L.circle(latlng, radius, {
        fill: true,
        fillColor:'#fff',
        fillOpacity: 0.5,
        color: '#fff',
        opacity: 0.5,
        startAngle: 20,
        stopAngle: 340
    }).addTo(map);

    L.tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
        attribution: '&copy; <a href="http://openstreetmap.org">OpenStreetMap</a> contributors, <a href="http://creativecommons.org/licenses/by-sa/2.0/">CC-BY-SA</a>',
        maxZoom: 18
    }).addTo(map);
</script>

[jieter]

This is the quick fix:

L.CircleMarker = L.CircleMarker.extend({
    isSemicircle: function () { return false; }
});

[jieter]

Released v1.0.5

[buchanan-fh]

Thank you very much for your fast answer !