jina-ai / serve

☁️ Build multimodal AI applications with cloud-native stack
https://jina.ai/serve
Apache License 2.0
21.13k stars 2.22k forks source link

test_hub_build_push_push_again is either buggy or flaky #1542

Closed hanxiao closed 3 years ago

hanxiao commented 3 years ago

Describe the bug

FAILED tests/integration/hub_usage/test_hub_usage.py::test_hub_build_push_push_again

HubIO@4333[E]:Error when trying to push image jinahub/pod.encoder.dummy_mwu_encoder:0.0.6-0.8.14: TypeError("'str' object is not callable")

https://github.com/jina-ai/jina/pull/1541/checks?check_run_id=1610583362#step:5:7282

Plus, this skip condition looks very strangely written, how comes condition a string?

https://github.com/jina-ai/jina/blob/822d07506b7a1243532e0405d4323c1dc929508f/tests/integration/hub_usage/test_hub_usage.py#L123-L124

Describe how you solve it

I'm disabling this test until it is fixed.


Environment

Screenshots

deepankarm commented 3 years ago

@rutujasurve94 Thought https://github.com/jina-ai/jina/pull/1492 resolved this. Can you please take a look?

rutujasurve94 commented 3 years ago

Hi, raised PR: https://github.com/jina-ai/jina/pull/1560 for this. Should work with this fix