Open NarekA opened 11 months ago
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
9eb4d09
) 72.61% compared to head (2856423
) 49.55%. Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@JoanFM I'm happy to change the parameter to headers, but I'm afraid it's too close to header
which I've noticed is used for passing request_id
during orchestration. How about request_headers
?
@JoanFM I'm happy to change the parameter to headers, but I'm afraid it's too close to
header
which I've noticed is used for passingrequest_id
during orchestration. How aboutrequest_headers
?
it does not matter, header is something that is quite hidden from the Executor developer. I would still use headers
This PR is attempts to implement the solution in the discussion of https://github.com/jina-ai/jina/issues/6049. It adds a new parameter
metadata
for jina endpoints which can be used to pass in http headers or GRPC metadata.This PR only implements the http headers, GRPC metadata will have to be done in a separate PR
Goals:
TODO: