Closed zac-li closed 9 months ago
Attention: Patch coverage is 0%
with 35 lines
in your changes are missing coverage. Please review.
Project coverage is 75.04%. Comparing base (
af406ce
) to head (8577b09
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
jina/serve/runtimes/worker/http_sagemaker_app.py | 0.00% | 31 Missing :warning: |
jina/serve/executors/__init__.py | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
tests are failing
Goals: This PR made a required improvement (based off of https://github.com/jina-ai/jina/pull/6055/) on the SageMaker Batch Transform routine so that Reranking SageMaker model can perform Batch Transform as expected.
Previously, Jina Batch Transform endpoint has no problem reading simple data in each row from CSV and construct a input model and perform inference, for example, for
0f37fc919deb46e8bcafd92f1feba65f, simple text
, it will be converted to:However, for more complex model (e.g., includes
List
of models), such as:which is represented as such in CSV:
The original implementation would fail when parsing.
So this PR proposed a
construct_model_from_line
that can deal with more complex cases like above.Test cases have been added to verify the fix.