search

jkeen / ember-stereo

The best way to reactively handle audio in your modern ember app
https://ember-stereo.com
MIT License
19 stars 3 forks source link

Fix tracked values being updated in the same runloop they were used #11

Closed fusion2004 closed 2 years ago

fusion2004 commented 2 years ago

This was the main error I was getting when trying to use any of the helpers in a ember 4.4 app!

From what I can tell... it doesn't seem like anything that actually renders relies on updates to the proxy cache? (I'm super unsure of this tho, lol.)

So I made an untracked version of the object cache and had the proxy cache use it, and so far things seem to work without issue now.

jkeen commented 2 years ago

Great find! I picked out a few things I did in my other branch to see if we can get all these tests passing

jkeen commented 2 years ago

:tada: This PR is included in version 3.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: