search

jniemann66 / react-chessdiagram

Chess Diagram React Component
MIT License
26 stars 10 forks source link

Properly remove event listeners in componentWillUnmount #14

Closed gkaemmer closed 6 years ago

gkaemmer commented 6 years ago

Fixes a bug where .getBoundingClientRect is still called on scroll after board is unmounted.

jniemann66 commented 6 years ago

Nice one ! Thanks for that.

gkaemmer commented 6 years ago

No problemo! Could you cut a release for the change?

Really appreciate this library! Thanks for putting it together.

jniemann66 commented 6 years ago

Sure. It's up now : https://www.npmjs.com/package/react-chessdiagram