jo-mueller / RadiAiDD

Positioning Software for mouse brain irradiation
MIT License
6 stars 0 forks source link

Replace PyQt imports with qtpy #21

Open jo-mueller opened 2 years ago

jo-mueller commented 2 years ago

importing PyQt in Python projects is one of the key ways to screw up repositories. It would be better to change all imports that rely on PyQt5 (which are A LOT in this project) to qtpy imports, which forms a compatibility layer above PyQt5 and should thus be more compatible with other platforms/computer/environments/etc

@schneidorlein, can I assign you to this? It would also be a nice exercise on how to work with github (I've only really learned it myself recently, tbh^^").

The conduct would be this:

Let me know if you need any help with this!

schneidorlein commented 2 years ago

I can try this (#21 and #22), but I also do not have a lot of experience with Github yet :D How urgent is it? ;)

jo-mueller commented 2 years ago

Ah - there's a comment :) Feel free to always add @jo-mueller to the comment, then I'll get notified.

jo-mueller commented 2 years ago

How urgent is it? ;)

Not at all. Consider these tasks to be opportunities to get to know github a bit better (it's really powerful) within the scope of relatively small changes.

jo-mueller commented 2 years ago

Added qtpy to deps in #26