joao-carloto / FireRobot

Firefox extension for Robot Framework/Selenium.
Other
28 stars 6 forks source link

Absent toolbar icon breaks the selection mode #29

Closed netvato closed 9 years ago

netvato commented 9 years ago

Issue:

The FireRobot add-on can be activated, however selecting the elements on the page does not populate the 'HTML' or 'Test Cases' windows. Right clicking on an element does not bring up the context window.

Notable is once the add-on is closed, all items on that TAB remain inaccessible changing to another TAB on the same browser window and right-clicking on an element now brings up the FireRobot context window. Selecting one of the context items presents the following message:

Warning! There are no selected elements.

I've installed v1.0.5 on the following systems: OSX 10.9.4, FF 31.1.0 (ESR) Ubuntu 14.04 FF 30.0 WIndows 7(64) FF 31.1.0 (ESR).

I tested with the following website, http://www.wufoo.com/gallery/templates/registrations/workshop-registration/, to eliminate the possibility that the website is not fully loading the page.

In the Browser Console, I seeing the following messages when I attempt to select elements and right-click on them:

reflow: 0.18ms selectedElements is undefined select.jsm:301 reflow: 0.2ms function _calcMouseTargetRect, tabbrowser.xml line 4993 reflow: 0.21ms browserWindow is null select.jsm:249 selectedElements is undefined select.jsm:312

joao-carloto commented 9 years ago

Hi netvato, thanks for the contribution.

The only way I could partially replicate the symptoms you describe was this:

The thing that worries me the most, is that you could close FireRobot and keep the context menu. That I could not yet replicate.

Could this scenario explain part of your issues? Can you replicate this having only one tab open?

netvato commented 9 years ago

Hey joao-carloto, thanks for your reply and suggestion.

I tried again using Mac OSX and Ubuntu, with a single tab.

Rather then trying to show with words what I am seeing, I made a video that I posted on YouTube here:

https://www.youtube.com/watch?v=3XlrCzaG37w&feature=youtu.be

I show what Extensions and Plugins are associated with my FF 30.0 installation on Ubuntu 14.04.

In addition, after enabling select mode, I go from element to element and both click and right-click. Neither garners a response. As I stated before, I can no longer complete operations in that tab.

In this test, I did not close FireRobot, but open a new tab towards the end. The new tab allows me to access the web page, but now right-clicking presents the FireRobot context menu instead of the 'normal' FF context menu. This is true for all tabs that I open subsequent to initializing FireRobot.

Hope this helps.

joao-carloto commented 9 years ago

I found it!

The only relevant difference between your setup and mine was that you were not using the toolbar icon to open the extension. I have it on my browser since I started developing and never thought on removing it. The extension tries to change the icon style when opening, but since it wasn't there it would fail. The subsequent lines of code on the same function would not run and that was causing the trouble.

I'll be making a new version now (1.0.6). Please try it and confirm the fix. I hope you don't mind me changing the issue title to something more specific.

Many thanks! You're the man! Whenever you come to Portugal I pay you a beer.

Cryton1000 commented 9 years ago

I can confirm this. I had the same issue yesterday and posted a issue here. But messed around trying to figure it out. I accidently fixed it and deleted the issue. I did not know how until this morning reading up on your post here. Thanks :)

And btw: Thanks for this awesome addon! With this i can develop much faster.

Question: IS there any support for css as locator comming up in later versions?

joao-carloto commented 9 years ago

Hi Cryton1000, thanks for the input. Regarding your question about CSS locators: I'm currently working on issue #22, but issue #21 is about CSS locators and I might go for that one afterwards. Feel free to leave your input.