search

jocosocial / tricordarr

A Twitarr client for Android
GNU General Public License v3.0
6 stars 3 forks source link

Try to reproduce the 2024 onboard network critical fault #179

Closed cohoe closed 1 month ago

cohoe commented 3 months ago

Somewhat related to #125

Public DNS record went to a landing page Private DNS record went to the server

Cellular and restrictive WiFi on at the same time, might have even authenticated through Navigator.

App would grey screen of death and be un-usable without clearing all data.

cohoe commented 2 months ago

It's here! https://github.com/jocosocial/tricordarr/blob/main/src/components/Navigation/Tabs/BottomTabNavigator.tsx#L55

08-28 22:48:02.927 22466 22513 E unknown:ReactNative: TypeError: Cannot read property 'map' of undefined
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: This error is located at:
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in BottomTabNavigator
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in StaticContainer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in EnsureSingleNavigator
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SceneView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in DebugContainer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in MaybeNestedStack
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RNSScreen
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Suspender
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Suspense
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Freeze
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in DelayedFreeze
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in InnerScreen
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Screen
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SceneView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Suspender
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Suspense
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Freeze
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in DelayedFreeze
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RNSScreenStack
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ScreenStack
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in NativeStackViewInner
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SafeAreaProviderCompat
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in NativeStackView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PreventRemoveProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in NavigationContent
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in NativeStackNavigator
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RootStackNavigator
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in FilterProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AnimatedComponent(View)
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AnimatedComponent(View)
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PanGestureHandler
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PanGestureHandler
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Drawer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RNGestureHandlerRootView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in GestureHandlerRootView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Drawer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AppDrawer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in DrawerProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in CruiseProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in HeaderButtonsProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Portal.Host
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ModalProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in FeatureProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in UserNotificationDataProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in UserRelationsProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in TwitarrProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SocketProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PrivilegeProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in UserDataProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AuthProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in LoadingProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in QueryClientProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PersistQueryClientProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SwiftarrQueryClientProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ErrorHandlerProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in StyleProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ThemeProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Portal.Host
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RNCSafeAreaProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SafeAreaProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in SafeAreaProviderCompat
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in PaperProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in EnsureSingleNavigator
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in BaseNavigationContainer
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ThemeProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in NavigationContainerInner
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AppNavigationThemeProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in ConfigProvider
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RNGestureHandlerRootView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in GestureHandlerRootView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in App
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in RCTView
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in Unknown
08-28 22:48:02.927 22466 22513 E unknown:ReactNative:     in AppContainer, js engine: hermes, stack:
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: getForumBadgeCount@1:3032358
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: BottomTabNavigator@1:3031774
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: renderWithHooks@1:396299
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: beginWork@1:445090
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: performUnitOfWork@1:431104
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: workLoopSync@1:430171
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: renderRootSync@1:430002
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: flushSyncWorkAcrossRoots_impl@1:385757
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: scheduleUpdateOnFiber@1:427466
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: dispatchSetState@1:400717
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: ?anon_0_@1:1785593
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: asyncGeneratorStep@1:584636
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: _next@1:584893
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: anonymous@1:239225
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: _callTimer@1:238176
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: _callReactNativeMicrotasksPass@1:238320
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: callReactNativeMicrotasks@1:240315
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: __callReactNativeMicrotasks@1:102179
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: anonymous@1:101262
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: __guard@1:102017
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: flushedQueue@1:101173
08-28 22:48:02.927 22466 22513 E unknown:ReactNative: invokeCallbackAndReturnFlushedQueue@1:101116
cohoe commented 2 months ago

Simulator wifi network has prod.twitarr.com going to an internal IP with the instance. Public cellular resolves to a static HTML page. Switching networks and restarting the app triggers the failure.

cohoe commented 2 months ago

Happening with any API call. The call is made, doesn't get an error (HTTP 200 response), but the body is the HTML. I expect there is JSON data in there but there isn't. It poisons the app because the query result is cached.

cohoe commented 2 months ago

Relevant nginx config that's causing this:

server {
  listen 80;
  server_name prod.twitarr.com twitarr.com;
  location / {
    root /app;
    try_files $uri $uri/ /index.html;
  }
}

Returns 200 and the contents of index.html for any request.

cohoe commented 1 month ago

I believe this is addressed by not doing the nginx shenanigans, some new Axios protections, and a global error catcher that can clear the query cache.