search

joeyates / imap-backup

Backup and Migrate IMAP Email Accounts
MIT License
1.37k stars 75 forks source link

Add multi-step dockerfile and example compose #171

Closed mchangrh closed 1 year ago

mchangrh commented 1 year ago

This image differs from the debian build in that it is not designed to be run interactively but to run automatically. automatic cron runs would not be difficult but not sure if that would be desirable. bash is not present and the entrypoint is passed in, eliminating the need for binstubs

I'm not sure how you would like documentation for running to be handled, so I will await your guidance.

alpine linux was chosen because of it's much smaller size (37MB) compared to bullseye (340MB) but most importantly to this project, bash is dropped in favor of ash

joeyates commented 1 year ago

Hi @mchangrh

Thanks for proposing a contribution to the project.

However, I'd like to consider a couple of points.

Firstly, this PR breaks stuff! It modifies the docker-compose.yml file that is an integral part of the development workflow when running tests. Whatever happens with future developments with the project, it still needs to be possible to continue testing changes. As it stands, this PR could not be accepted for this reason alone.

Secondly, this PR seems to be a strong departure from the current project. It's not clear what problem it is trying to resolve. For this reason, I'm going to close this PR for now.

Please open an issue that explains the use case you are addressing. Once the problem is clear, and the approach for resolving the problem is agreed upon, we can progress to looking at an implementation.