Arg options

[johan-v-r]

This is an adaption of @JelleHissink PR to support specifying directory and folder exclusion.

[JelleHissink]

I like the tool, the minimal setup without npm. however the msbuild integration just falls short for me.

I noticed you took a different approach... I don't know the plan you have for my PR now? Reckon you will remove it, however for me I mainly have issues that the project just does not rebuild if I don't edit the project file:

• I have to force-rebuild 2 times... once for the .css files to get generated, once for the generated css to get correctly bundled...

• I tried to let it tie in more with the .net build ecosystem instead of making a post-build executable that will be executed.

• I agree the commandline tool should be usable as well...

• However the current .targets and .props force me to manually edit my .csproj commandline arguments for the tool, as well as maintain the expression for (in a separate task as all other msbuild sdk's do)

• Forcing an entire sass process of all files (reading all files 2 times, writing none if nothing changed) looks more expensive than my optimization to skip when 1 file changed.

• Msbuild would provide integration in Watch/SASS files, globbing patterns, exclude patterns

• Msbuild parameters should be used for specifying sass compile options

• Instead of using common globbing patterns in my project file, I have to learn/remember the commandline syntax of the underlying tool.

• Watch, DisableFastUpToDateCheck are now present in 4 projects at my end already... Watch effectively forces me to specify include/excludes 2 times... or come up with a parameter and string replacement that is more limiting.

Just my 2 cents, it is your project, you are free to take this route. However looking at this PR in the current state the msbuild integration is taking a big step backwards.

[JelleHissink]

I have been looking at your code some more, I think this is the way to go for the tool. And in the future using the command options we might be able to provide some input for CompilationOptions.

However for the integration in msbuild to me it still seems as the only way to go is to determine the file list there. How could we pass the file list? I only see a few options here:

• Passing all files as arguments (commandline string length might cause problems)
  • Prefix with -f for file?
  • Determine if it is a file or a directory based on the File.Exists() check?
• Passing the file list using stdin
• Passing a listing file
• Create a custom msbuild task so we can directly interface between msbuild and the tool?

Is the default positional argument going to cause problems in the long run? E.g. what if a list of files is passed, how is the current directory then not scanned?

[johan-v-r]

Yes that's the idea! I see the tool assisting MSBuild, but not depending on it. So yeah passing in a list of filepaths would work great - as I see you've already done in the other PR.

I think when a list of files are provided with -f or something, that would make sense to override the default behavior. In that case the user is specifying the exact file and not directory, or perhaps it should look for that file in the directory...? That can come with your changes.

The compilation options would fit as part of the MSBuild task which we can include, but we should then also allow users to easily disable it in their projects (not everyone might want that).

I'm merging this first so we can build on this further on yours 👍