search

johnmcfarlane / cnl

A Compositional Numeric Library for C++
Boost Software License 1.0
632 stars 63 forks source link

Try to fix issue #991 #1041

Closed vrqq closed 1 year ago

vrqq commented 1 year ago

Hello, the code in issue 991 still have some problem, and I try to re-fix it here. ( https://github.com/johnmcfarlane/cnl/issues/991#issuecomment-1031424302)

Still some test failed. (see the issue previous)

johnmcfarlane commented 1 year ago

Hi, You appear to be proposing merging a branch with a branch other than main. Can you simply make a PR to merge all of vrqq:991 with johnmcfarlane:main?

vrqq commented 1 year ago

Sure but there's some test failure like std::hash<path> and build scripts.

johnmcfarlane commented 1 year ago

Are they because of the changes proposed in the PR?

On Fri 17 Mar 2023, 14:20 vrqq, @.***> wrote:

Sure but there's some test failure like std::hash and build scripts.

— Reply to this email directly, view it on GitHub https://github.com/johnmcfarlane/cnl/pull/1041#issuecomment-1473917575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFTGNYH2XJQPQFKFA2U7DDW4RXJXANCNFSM6AAAAAAVWQA6VM . You are receiving this because you commented.Message ID: @.***>