Errors building c51e92dbfb851984b3f5feff15849e701b593a13

[jgarte]

LDFLAGS       =
gcc -fPIC `pkg-config --cflags x11` `pkg-config --cflags gtk+-3.0 gcr-3 webkit2gtk-4.0` -DVERSION=\"0.1\" -DGCR_API_SUBJECT_TO_CHANGE  -DLIBPREFIX=\"/gnu/store/vzc4k3wy8grhdxlpjim7vw5s0jypxfc9-boredserf-0.8.4/lib\" -DWEBEXTDIR=\"/gnu/store/vzc4k3wy8grhdxlpjim7vw5s0jypxfc9-boredserf-0.8.4/lib/boredserf\"  -D_DEFAULT_SOURCE -O1 -c boredserf.c filter.c common.c shellish.c board.c marks.c
In file included from boredserf.c:37:
config.h:32:27: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘/’ token
   32 | const char *selector_find_/gnu/store/gdgzmbw0bqncr39yk1jxzfra93lyx2fc-dmenu-5.0/bin/dmenu[] = {
      |                           ^
In file included from boredserf.c:37:
config.h:32:27: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘/’ token
   32 | const char *selector_find_/gnu/store/gdgzmbw0bqncr39yk1jxzfra93lyx2fc-dmenu-5.0/bin/dmenu[] = {
      |                           ^
In file included from boredserf.c:37:
config.h:32:27: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘/’ token
   32 | const char *selector_find_/gnu/store/gdgzmbw0bqncr39yk1jxzfra93lyx2fc-dmenu-5.0/bin/dmenu[] = {
      |                           ^
In file included from boredserf.c:37:
config.h:32:27: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘/’ token
   32 | const char *selector_find_/gnu/store/gdgzmbw0bqncr39yk1jxzfra93lyx2fc-dmenu-5.0/bin/dmenu[] = {
      |                           ^
make: *** [Makefile:34: common.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:34: boredserf.o] Error 1
make: *** [Makefile:34: filter.o] Error 1
make: *** [Makefile:34: shellish.o] Error 1
error: in phase 'build': uncaught exception:

Hi, any thoughts on what might be wrong in the build?

[jonbakke]

Hi there!

From those warnings, I want to see config.h; it looks like the array wasn't closed properly, which is very easy to do when working with these shell commands.

I also make breaking commits fairly often, and make commits with dumb mistakes in them that (I hope!) are quickly fixed, so pulling the latest code and building from config.def.h (e.g., by removing/renaming your config.h) is a good way to find a "known good" configuration that helps locate the problematic difference.

In general, if I break something you/anyone cares about, do let me know! Helping folks fix their configuration teaches me about how they use the program, so it is often a win/win process.