TypeError: input.trim is not a function

[bhtw]

Error:

Cannot convert Postman collection due to error TypeError: input.trim is not a function.

How to reproduce:

• Create a clean project
• Install the postman-to-openapi as library (npm i postman-to-openapi --save)
• From your github download the 'Responses.json' file as collection sample
• Use the async/await function to convert
• Run the script from cli with node

code used

const postmanToOpenApi = require('postman-to-openapi')

const postmanCollection = require("./sampleCollections/responses.json")
const outputFile = './openApi/responses.yml'

const convert = async () => {
  try {
    const result = await postmanToOpenApi(postmanCollection, outputFile, options)
    console.log(`OpenAPI specs: ${result}`)
  } catch (err) {
    console.log(err)
  }
}

convert()

Result

TypeError: input.trim is not a function
    at resolveInput (/home/server/btw/dev/api/postman2openapi/node_modules/postman-to-openapi/lib/index.js:605:13)
    at postmanToOpenApi (/home/server/btw/dev/api/postman2openapi/node_modules/postman-to-openapi/lib/index.js:18:30)
    at convert (/home/server/btw/dev/api/postman2openapi/main.js:12:26)
    at Object.<anonymous> (/home/server/btw/dev/api/postman2openapi/main.js:47:1)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10)
    at Module.load (node:internal/modules/cjs/loader:1004:32)
    at Function.Module._load (node:internal/modules/cjs/loader:839:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Purposed solution

• Check typeof input.
• If not a string, convert to string (then trim will work)

I made this change, and then it worked:

• File: index.js
• Function: resolveInput(input)

  async function resolveInput(input) {
  if (typeof input === 'object') {
  input = JSON.stringify(input)
  }
  if (input.trim().startsWith('{')) {
  return input
  } else {
  return readFile(input, 'utf8')
  }
  }

I guess you should do more checks or something, but this fix made it work for me. And if you have more places where you do a trim without checking if the parameter is a String, then this should be impelented too, I guess.

Hope this helps others as well that might have had this issue.

[joolfe]

Hi @bhtw,

That´s not a bug, as you can read in the documentation here the parameter input is defined as String. Path of the Postman collection file or value of the postman collection as String., you are not providing a string so you are breaking the contract ;-), that's all.

If you want a new feature that accept the input as an object just open a feature request please but not a bug.

Best regards.