search

joomla-projects / webservices

Webservices working group repository
GNU General Public License v2.0
16 stars 9 forks source link

Update InstallController.php #27

Closed chrisdavenport closed 8 years ago

chrisdavenport commented 8 years ago

Add context name for WebservicesModel constructor. Throw a temporary exception when attempting to install in batch mode. Fix code style issues.

wilsonge commented 8 years ago

This seems wrong. The __construct takes a config array (https://github.com/joomla-projects/webservices/blob/chrisdavenport-patch-2/component/admin/Webservices/Model/FormModel.php#L78) which isn't actually then used anyhow (I dunno if it's supposed to be injected into the Registry object being created there. Either way - injecting a string into this model like you are doing on line 33 has to be wrong!

chrisdavenport commented 8 years ago

The model that's being instantiated is this one: https://github.com/joomla-projects/webservices/blob/develop/component/admin/Webservices/Model/WebservicesModel.php#L82

wilsonge commented 8 years ago

OK I'm blind. Apologies