fix: all_ok check for empyt GRangesList (see issue #126)

jorainer / ensembldb

This is the ensembldb development repository.

https://jorainer.github.io/ensembldb

33 stars 10 forks source link

fix: all_ok check for empyt GRangesList (see issue #126) #127

Closed lgatto closed 2 years ago

lgatto commented 2 years ago

This PR fixes

the all_ok check documented in issue #126
the corresponding message that now thrown before filtering those that are ok and takes NAs into account.

lgatto commented 2 years ago

Out of curiosity, why do you return NA and not FALSE in that all_ok test? The latter wouldn't require to specify na.rm = TRUE in the sum() in the message.

lgatto commented 2 years ago

PR updated to also handle empty elements later in the code. All details in #126

lgatto commented 2 years ago

That's a good start for 2022! :-)

All the best to you and your family!