jorainer / ensembldb

This is the ensembldb development repository.
https://jorainer.github.io/ensembldb
33 stars 10 forks source link

Turn regular function proteinToGenome() into S4 method #140

Closed hpages closed 1 year ago

hpages commented 1 year ago

Hi,

In BioC 3.15 proteinToGenome() became an S4 generic function defined in the GenomicFeatures package, with two methods: a default method (that will typically operate on a TxDb object), and a method that operates on a GRangesList object. See ?GenomicFeatures::proteinToGenome for the details.

Following this change, the proteinToGenome() function defined in the ensembldb package needs to be turned into an S4 method that operates on an EnsDb object.

Note that this PR requires GenomicFeatures >= 1.49.6 which should become available in BioC 3.16 via BiocManager::install() in the next 24-48 hours.

Cheers, H.