josechagas / ActionSheetView

Project for managing and using any ViewController with an ActionSheet style.
MIT License
10 stars 0 forks source link

ActionSheetViewDelegate not calling implemented stubs #1

Closed askari01 closed 6 years ago

askari01 commented 6 years ago

self.delegate adding stubs but not calling them on navigation viewController

askari01 commented 6 years ago

self.containerView.frame.size.height is empty (nil value)

josechagas commented 6 years ago

Hey askari01 after reading your messages I reviewed the project and I am not sure if I found a solution, so I have some possibilities.

1 - Probably you are forgetting to inform the segue identifier to your class that inherits from ASManagerVC. I think this is not the case because without the identifier your ActionSheetView does not appear.

2 - Take a look if you are removing the childViewControllers from your class that inherits from ASManagerVC.

If any of these options are not the solution please give me a better explanation about the situation for I try to reproduce here, for example what are the source and destination UIViewControllers of ASViewSegue segue.

I am sorry for not answering faster.

josechagas commented 6 years ago

3 - Your destination UIViewController class of ASViewSegue segue now really needs to implement ActionSheetView protocol.

If this is the problem I will fix README file because its not so clear.

askari01 commented 6 years ago

the view is rootViewController segue is implemented not removing AsManagerVC class actionSheetView protocols are implemented but still not working.

askari01 commented 6 years ago

ActionSheetViewDelegate func are not being called

josechagas commented 6 years ago

"the view is rootViewController", so your segue points to a UINavigationController ?! If this is true your UINavigationController needs to implement ActionSheetView

askari01 commented 6 years ago

it is implementing ActionSheetView, is it possible that u look at my code ?

josechagas commented 6 years ago

make RatingTestVC implement ActionSheetView protocol and test.

askari01 commented 6 years ago

Navigation:

screen shot 2018-02-17 at 12 10 16 am

Action Sheet View

screen shot 2018-02-17 at 12 12 36 am

ASManager and Delegate

screen shot 2018-02-17 at 12 15 03 am

Segue

screen shot 2018-02-17 at 12 19 53 am
josechagas commented 6 years ago

Are you overriding viewWillAppear method on your class that inherit ASManagerVC ? If yes call super.viewWillAppear inside of it.

josechagas commented 6 years ago

Looking for the images it seems to be everything ok.

josechagas commented 6 years ago

is it of your class WaitingVC or from my class ASManagerVC ? If its from your class, you do not need to call the methods performSegue and tryToAddDarkLayer for it works

askari01 commented 6 years ago

calling super.viewWillAppear solved it for me, how silly of me. if you allow can I close and comment

josechagas commented 6 years ago

I am really happy it worked and I am sorry because my documentation was not so clear, I will fix it to avoid other problems like this.

You can close it and comment.

askari01 commented 6 years ago

thank you very much, for your time and help, I really like your pod. Have a good day mate.

thanks