josechagas / ActionSheetView

Project for managing and using any ViewController with an ActionSheet style.
MIT License
10 stars 0 forks source link

is there any way to tap to dismiss the view #3

Open vanillasky771 opened 5 years ago

josechagas commented 5 years ago

Now it does not contain a dismiss animation or some kind of dismiss method of UIViewController. What you can do is change 'ASManagerVC.asViewIsHidden' property value to hide or not your current instance of 'ActionSheetView'.

If you really need to present and dismiss it, probably you want something like:

I hope I have helped,Thank you @vanillasky771.

vanillasky771 commented 5 years ago

For this I created solution with setting the height of the viewController so when it’s open the height is set to 0 if the user drop down then it close like the one in BulletinBoard

It’s possible when the sheet open the back layer is disabled ? I mean when the sheet is open, and the top side of sheet is tapped, the sheet close

Thank you for your response Very appreciate it 😁

On 3 Jan 2019, at 08.32, José Lucas Souza das Chagas notifications@github.com wrote:

Now it does not contain a dismiss animation or some kind of dismiss method of UIViewController. What you can do is change 'ASManagerVC.asViewIsHidden' property value to hide or not your current instance of 'ActionSheetView'.

If you really need to present and dismiss it, probably you want something like:

https://github.com/alexaubry/BulletinBoard https://github.com/alexaubry/BulletinBoard Custom Transition, this link has a good tutorial: https://www.raywenderlich.com/322-custom-uiviewcontroller-transitions-getting-started https://www.raywenderlich.com/322-custom-uiviewcontroller-transitions-getting-started I hope I have helped, if possible tell me which solution used, it can help me in the future, thank you @vanillasky771 https://github.com/vanillasky771 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/josechagas/ActionSheetView/issues/3#issuecomment-451027656, or mute the thread https://github.com/notifications/unsubscribe-auth/AY61n0pfgIZouHxDbmsBgrSjoObDv36Lks5u_U-NgaJpZM4ZkaHE.

josechagas commented 5 years ago

This is a good solution, I created it and did not have this idea, kkk.

"It’s possible when the sheet open the back layer is disabled ?"

You can disable back layer, all you have to do is implement 'ActionSheetViewDelegate .showDarkBackgroundLayer()' method returning always false. I am sorry you did not realized that, as soon as possible I will improve the documentation.

I mean when the sheet is open, and the top side of sheet is tapped, the sheet close

I started to implement something like this, but I decided not add it. I did not added this feature but you can implement it, take a look on next section.

To add other customizations like different gestures on your ActionSheetView follow the steps.

@objc private func didTapOnASView(tapGes:UITapGestureRecognizer){ //call these methods as you need to change state. changeToBigDimensions(Animate: true) changeToSmallDimensions(Animate: true) }

vanillasky771 commented 5 years ago

Yeah I you need to update the documentation too kkk Thank you for this solution 😁

On 4 Jan 2019, at 07.39, José Lucas Souza das Chagas notifications@github.com wrote:

This is a good solution, I created it and did not have this idea, kkk.

"It’s possible when the sheet open the back layer is disabled ?"

You can disable back layer, all you have to do is implement 'ActionSheetViewDelegate .showDarkBackgroundLayer()' method returning always false. I am sorry you did not realized that, as soon as possible I will improve the documentation.

I mean when the sheet is open, and the top side of sheet is tapped, the sheet close

I started to implement something like this, but I decided not add it. I did not added this feature but you can implement it, take a look on next section.

To add other customizations like different gestures on your ActionSheetView follow the steps.

on method 'ActionSheetViewDelegate.bottomVC( vc: UIViewController)' where vc is the instance of your 'ActionSheetView' you can add new gestures to it, for example: func bottomVC( vc: UIViewController) { let tapGes = UITapGestureRecognizer(target: self, action:#selector(ASManagerVC.didTapOnASView(tapGes:))) self.view.addGestureRecognizer(tapGes) }

@objc private func didTapOnASView(tapGes:UITapGestureRecognizer){ //call these methods as you need to change state. changeToBigDimensions(Animate: true) changeToSmallDimensions(Animate: true) } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/josechagas/ActionSheetView/issues/3#issuecomment-451323312, or mute the thread https://github.com/notifications/unsubscribe-auth/AY61n4Nn6s334ynXb8gbJcMaoUcWBuZHks5u_qLOgaJpZM4ZkaHE.

josechagas commented 5 years ago

@vanillasky771 if you consider this issue solved, could you close it ?